Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade to Postgres 15 #10534

Merged
merged 1 commit into from
Dec 10, 2024
Merged

deps: Upgrade to Postgres 15 #10534

merged 1 commit into from
Dec 10, 2024

Conversation

Betree
Copy link
Member

@Betree Betree commented Dec 9, 2024

Key changes:

  • Update table permissions since schema default permissions changed in PG 15 (see deps: Upgrade to Postgres 15 #10534 (comment)).
  • Update CI jobs to ubuntu-24.04 (which is supposed to become the default in the next coming days) to install postgres-client-16 and make sure we use the latest tooling for restoring.

@Betree Betree self-assigned this Dec 9, 2024
@Betree Betree changed the title deps: Upgrade to PG 15 deps: Upgrade to Postgres 15 Dec 9, 2024
@Betree Betree force-pushed the deps/pg15 branch 15 times, most recently from cd8110c to c28eb51 Compare December 10, 2024 08:08
Comment on lines +65 to +73
- name: Install dependencies
run: |
sudo apt-get install \
`# Cypress dependencies - see https://docs.cypress.io/app/get-started/install-cypress#UbuntuDebian` \
libgtk2.0-0t64 libgtk-3-0t64 libgbm-dev libnotify-dev libnss3 libxss1 libasound2t64 libxtst6 xauth xvfb \
`# Postgres client` \
postgresql-client-16 \
`# GraphicsMagick (not sure if needed)` \
graphicsmagick
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single command for faster install

Comment on lines +77 to +80
# Update table permissions
echo "Updating table permissions"
psql -U postgres -h localhost $LOCALDBNAME -c "GRANT ALL ON SCHEMA public TO ${LOCALDBUSER};"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kewitz
Copy link
Contributor

kewitz commented Dec 10, 2024

Should we go to 16.4 to match production?

@Betree
Copy link
Member Author

Betree commented Dec 10, 2024

Should we go to 16.4 to match production?

It's the next step, but I want to make it incremental to easily rollback if it's not working for some in the team.

@Betree Betree merged commit 38da99e into main Dec 10, 2024
20 checks passed
@Betree Betree deleted the deps/pg15 branch December 10, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants