Migrate payments and Transactions to typescript #9896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znarf
force-pushed
the
typescript-payments
branch
6 times, most recently
from
29d14f3 to
0ef57b4
Compare
Closed
znarf
force-pushed
the
typescript-payments
branch
from
0ef57b4 to
fdf082e
Compare
znarf
force-pushed
the
typescript-payments
branch
2 times, most recently
from
3f7d9e7 to
0824a70
Compare
znarf
force-pushed
the
typescript-payments
branch
4 times, most recently
from
0b35982 to
2468e66
Compare
znarf
force-pushed
the
typescript-payments
branch
from
2468e66 to
8c8defc
Compare
znarf
force-pushed
the
typescript-payments
branch
from
9dafa4c to
4fdde88
Compare
SudharakaP
reviewed
Apr 26, 2024
Comment on lines
+752
to
+754
| if (transaction) { | ||
| sendEmailNotifications(order, transaction); | ||
| } |
There was a problem hiding this comment.
@znarf : This stops sending emails for pending contributions I believe as evidenced here; https://opencollective.freshdesk.com/a/tickets/344191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9848