Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle protected expense attachments #10824

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hdiniz
Copy link
Contributor

@hdiniz hdiniz commented Nov 28, 2024

@hdiniz hdiniz self-assigned this Nov 28, 2024
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:38pm
opencollective-styleguide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:38pm

components/expenses/ExpenseItemForm.js Outdated Show resolved Hide resolved
lib/image-utils.js Outdated Show resolved Hide resolved
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this version, but I see no blocker just looking at the code. Getting the file type from GraphQL looks much simpler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants