Support for reading RX_FREQUENCY_OFFSET_PPM, RX_SNR and FEC_CORRECTED_BITS with SAI #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshitgulati18
force-pushed
the
phy_diags_aug_2023
branch
from
4259004
to
5a0252c
Compare
harshitgulati18
force-pushed
the
phy_diags_aug_2023
branch
3 times, most recently
from
eea6da6
to
7537895
Compare
kcudnik
approved these changes
Aug 17, 2023
JaiOCP
approved these changes
Aug 18, 2023
shri-khare
approved these changes
Aug 21, 2023
|
there's conflicts |
|
please fix build errors, maybe squash commit and force push will be required |
harshitgulati18
force-pushed
the
phy_diags_aug_2023
branch
2 times, most recently
from
d8ded6e
to
37182af
Compare
Signed-off-by: harshitgulati18 <hgulati@fb.com>
harshitgulati18
force-pushed
the
phy_diags_aug_2023
branch
from
37182af
to
70462df
Compare
|
Resolved the conflicts and the build errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes support for reading the following PHY layer diagnostics in SAI -
RX_FREQUENCY_OFFSET_PPM - Per lane frequency offset observed at the receiver serdes
RX_SNR - Per lane Signal to Noise ratio observed at the receiver serdes Note that the units chosen (value reported as a U16 in units of 1/256dB) to represent this value in SAI is similar to how transceiver management standards like SFF-8636 and CMIS represent them.
TOTAL FEC CORRECTED BITS - Represents the total bits corrected by the FEC (Forward Error Correction) as a monotonically incrementing counter. Note that SAI today has support for reading FEC Corrected codewords and symbols, but not the total corrected bits. The corrected bits counter will help in providing an accurate representation of the bit error rate on a link.
These are some useful diagnostics for debugging a link down or a link flap issue.