Support to get list of all reachable switch-id's from a fabric port #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
reviewed
Jun 12, 2024
inc/saiport.h
Outdated
| * @type sai_u16_list_t | ||
| * @flags READ_ONLY | ||
| */ | ||
| SAI_PORT_ATTR_FABRIC_REACHABILITY_VECTOR |
There was a problem hiding this comment.
dont put attributes after SAI_PORT_ATTR_CUSTOM_RANGE_END,
There was a problem hiding this comment.
HI kcidnik,
I tried putting it in middle , saimetadata checks were failing by saying enum shift , do i need to makes some changes to handle that ?
|
whiuch enum shift ? current metadata complains about ident, you will need to squash your commits since validator is only checking each commit separetly |
|
try first pass check on your dev machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to get a list of all reachable switch-id's from a fabric port, currently we can only check from switch-id if its reachable or not .
SAI_PORT_ATTR_FABRIC_REACHABILITY_VECTOR