Port Error Event Callback

[JaiOCP]

Callback for various errors observed by port.

[prgeor]

@JaiOC PCS errors means? Is it a counter value or some error indication? if later, what specific eror? PCS lane alignment error?

[prgeor]

@JaiOCP This Attribute does not seem to aligned with the PR description for error events. This is more of capability of the PHY which can support unreliable LOS enable. So, can we take this in a separate PR?

[JaiOCP]

It is a simple change. Can I update the title of the PR and comments to reflect that this is also included in this?

…

On Wed, Jul 10, 2024 at 3:15 PM Prince George ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In inc/saiport.h <#2048 (comment)> : > + * @brief Enable/Disable Port UNRELIABLE loss of signal + * + * @type bool + * @flags CREATE_AND_SET + * @default false + */ + SAI_PORT_ATTR_UNRELIABLE_LOS_ENABLE, + @JaiOCP <https://github.com/JaiOCP> This Attribute does not seem to aligned with the PR description for error events. This is more of capability of the PHY which can support unreliable LOS enable. So, can we take this in a separate PR? — Reply to this email directly, view it on GitHub <#2048 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKCSHLIWTVWWHG4QZHHUX7LZLWXADAVCNFSM6AAAAABKVYAJWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZQGQ3DOMJYGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.

[eddyk-nvidia]

Why should this event be sent via notification ? Or we want after falure on set to send it asynchroneously via notification from SAI to SWSS ?

[prgeor]

@JaiOCP Will this error event be notified to OA via port_change_event just like link up/down notification?

[prgeor]

@JaiOCP need a way to know if LF/RF is ASSERTED or DE-ASSERTED

[prgeor]

@JaiOCP can event notification provide the data to know if these error are currently asserted or not

[prgeor]

@JaiOCP can event notification provide the data to know if these error are currently asserted or not

[prgeor]

@JaiOCP can you please elaborate more on these failures. Are these failures during AN ?

[prgeor]

@JaiOCP Should we take these error notification as part of link up and link down. Also see during port init there will be notification for port that was down to begin with.

[JaiOCP]

Closing this PR.
Based on the offline discussion, port error events will be moved under the port_oper_status_t. This will help resolve the race condition of oper status events and error events going to orchagent in any order. Now all the events will be tracked via port_oper_status. This will also resolve the issue of nowing when the error state is cleared.