Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DASH Flow API to support connection tracking #2064

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

ShaofengWu123
Copy link
Contributor

@ShaofengWu123 ShaofengWu123 commented Aug 13, 2024

DASH Flow SAI APIs

Add API definitions, type extensions and object key of DASH Flow SAI APIs. The following files are modified:

  • experimental/saiexperimentaldashflow.h: DASH flow specific API definitions.
  • experimental/saiextensions.h: Add SAI_API_DASH_FLOW to sai_api_extensions_t.
  • experimental/saitypesextensions.h: Add type extensions of DASH flow.
  • inc/saiobject.h: Add sai_flow_entry_t flow_entry to sai_object_key_entry_t.

Signed-off-by: ShaofengWu123 <wsf123@link.cuhk.edu.hk>
@ShaofengWu123 ShaofengWu123 changed the title Update dash flow api [Draft] Update dash flow api Aug 13, 2024
Signed-off-by: ShaofengWu123 <wsf123@link.cuhk.edu.hk>
Signed-off-by: ShaofengWu123 <wsf123@link.cuhk.edu.hk>
@ShaofengWu123 ShaofengWu123 marked this pull request as ready for review August 13, 2024 08:58
@ShaofengWu123 ShaofengWu123 marked this pull request as draft August 13, 2024 08:58
Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@ShaofengWu123 ShaofengWu123 marked this pull request as ready for review August 22, 2024 04:42
@ShaofengWu123 ShaofengWu123 changed the title [Draft] Update dash flow api Update dash flow api Aug 22, 2024
@KrisNey-MSFT
Copy link

per @r12f - looks ready for merge please

experimental/saiextensions.h Outdated Show resolved Hide resolved
experimental/saitypesextensions.h Outdated Show resolved Hide resolved
experimental/saitypesextensions.h Outdated Show resolved Hide resolved
@ShaofengWu123 ShaofengWu123 changed the title Update dash flow api Add DASH Flow API to support connection tracking Aug 29, 2024
Signed-off-by: ShaofengWu123 <wsf123@link.cuhk.edu.hk>
…Y_ENI_MAC

Signed-off-by: ShaofengWu123 <wsf123@link.cuhk.edu.hk>
Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me now. thanks Shaofeng!

@prsunny prsunny merged commit e4b4268 into opencomputeproject:master Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants