Add packet trimming API #2077
Add packet trimming API #2077
Conversation
When a packet is lost, it can be recovered through fast retransmission (e.g., Go-Back-N in RoCE) or by using timeouts. Retransmission triggered by timeouts typically incurs significant latency. Packet trimming aims to facilitate rapid packet loss notification and, consequently, eliminate slow timeout-based retransmissions. Signed-off-by: Marian Pritsak <marianp@mellanox.com>
| * Try sending a shortened packet over a different | ||
| * queue. | ||
| */ | ||
| SAI_BUFFER_PROFILE_PACKET_ADMISSION_FAIL_ACTION_TRIM = 0x00000001, |
There was a problem hiding this comment.
drop and trim
There was a problem hiding this comment.
And counter behavior needs to be explained
There was a problem hiding this comment.
Add counter for trimmed packets
| * @flags CREATE_AND_SET | ||
| * @default 0 | ||
| */ | ||
| SAI_SWITCH_ATTR_PACKET_TRIMMING_DSCP_VALUE, |
There was a problem hiding this comment.
Should DSCP and QUEUE_INDEX be on a more granular level like on every buffer profile or port?
| /** | ||
| * @brief Disable packet trimming for a given match condition. | ||
| * | ||
| * This rule takes effect only when packet trimming is configured on a TC to which a packet belongs. |
There was a problem hiding this comment.
Please change "configured on a TC" to "configured on a buffer profile".
| /** | ||
| * @brief Disable packet trimming for a given match condition. | ||
| * | ||
| * This rule takes effect only when packet trimming is configured on a TC to which a packet belongs. |
There was a problem hiding this comment.
Should it be "TC" or "buffer profile"?
| * @flags CREATE_AND_SET | ||
| * @default 0 | ||
| */ | ||
| SAI_SWITCH_ATTR_PACKET_TRIMMING_QUEUE_INDEX, |
There was a problem hiding this comment.
What is expected behavior if TRIMMING_QUEUE experiences congestion ?
| * @flags CREATE_AND_SET | ||
| * @default 0 | ||
| */ | ||
| SAI_SWITCH_ATTR_PACKET_TRIMMING_QUEUE_INDEX, |
There was a problem hiding this comment.
If SAI_SWITCH_ATTR_QOS_DSCP_TO_TC_MAP, SAI_SWITCH_ATTR_QOS_TC_AND_COLOR_TO_DSCP_MAP, SAI_SWITCH_ATTR_PACKET_TRIMMING_DSCP_VALUE and SAI_SWITCH_ATTR_PACKET_TRIMMING_QUEUE_INDEX are all configured and if there are any conflicts between these configuration, what is the expected behavior ?
Different ASICs might want to resolve this in different ways
|
Can you also add the spec you are referring for this trimming feature ? |
When a packet is lost, it can be recovered through fast retransmission (e.g., Go-Back-N in RoCE) or by using timeouts. Retransmission triggered by timeouts typically incurs significant latency. Packet trimming aims to facilitate rapid packet loss notification and, consequently, eliminate slow timeout-based retransmissions.