Add Go 1.22 and 1.23, rm old versions, bump CI actions, bump golangci-linter #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
previously approved these changes
Aug 15, 2024
|
@opencontainers/runtime-tools-maintainers PTAL |
tianon
reviewed
Sep 21, 2024
|
@opencontainers/runtime-tools-maintainers PTAL 🙏🏻 |
1 task
Found by golangci-lint v1.60.1: cmd/oci-runtime-tool/main.go:59:17: printf: non-constant format string in call to github.com/sirupsen/logrus.Fatalf (govet) logrus.Fatalf(err.Error()) ^ Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Go 1.23 is released, making Go 1.21 (and older version) unsupported. Yet, let's also keep the version from go.mod. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Oh, interesting; I have a green check here, but I'm not in the maintainers list for this repo. Wondering if some permissions were set too relaxed? |
It looks like members of both runtime-tools-maintainers and runtime-spec-maintainers are admins here. |
|
@tianon we need a "still lgtm" from you here 🧔🏻 |
|
@opencontainers/runtime-tools-maintainers PTAL 🙏🏻 |
tianon
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a CI refresh. See commits for details.
Closes: #769