Skip to content

Commit

Permalink
Add Angular 17 support (#170)
Browse files Browse the repository at this point in the history
* chore: add mock angular.json and add @angular/cli package

* chore: update to ng17 compatible dependencies

* feat: update to Angular 17 compatible dependencies

* chore: cleanup

* chore: bump root package.json version

* docs: update documentation
  • Loading branch information
pvds authored Nov 16, 2023
1 parent 3e407f3 commit fef1d15
Show file tree
Hide file tree
Showing 8 changed files with 812 additions and 841 deletions.
6 changes: 3 additions & 3 deletions docs/coverage.html
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@
</td>
<td>injectable</td>
<td>SegmentService</td>
<td align="right" data-sort="88">
<span class="coverage-percent">88 %</span>
<span class="coverage-count">(23/26)</span>
<td align="right" data-sort="85">
<span class="coverage-percent">85 %</span>
<span class="coverage-count">(23/27)</span>
</td>
</tr>
<tr class="low">
Expand Down
194 changes: 147 additions & 47 deletions docs/injectables/SegmentService.html

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions docs/interfaces/SegmentPlugin.html
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ <h3>File</h3>
*
* @returns
*/
public identify(traits?: any, options?: any): Promise&lt;SegmentService&gt;;
public identify(traits: any, options?: any): Promise&lt;SegmentService&gt;;

/**
* The identify method is how you associate your users and their actions to a recognizable userId and traits.
Expand All @@ -246,7 +246,8 @@ <h3>File</h3>
*
* @returns
*/
public identify(userId?: string, traits?: any, options?: any): Promise&lt;SegmentService&gt; {
public identify(userId: string, traits?: any, options?: any): Promise&lt;SegmentService&gt;;
public identify(userId: string, traits?: any, options?: any): Promise&lt;SegmentService&gt; {
return new Promise((resolve) &#x3D;&gt; {
this._w.analytics.identify(userId, traits, options, _ &#x3D;&gt; resolve(this));
});
Expand Down
4 changes: 2 additions & 2 deletions docs/js/search/search_index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/properties.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
</ol>
<ul class="properties-list">
<li>
<b>Version</b> : 16.1.0</li>
<b>Version</b> : 17.0.0</li>
<li>
<b>Keywords</b> : angular, segment</li>
<li>
Expand Down
28 changes: 14 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@opendecide/ngx-segment-analytics",
"version": "16.1.0",
"version": "17.0.0",
"scripts": {
"build": "ng-packagr -p src/ng-package.json",
"build:watch": "yarn run build --watch",
Expand Down Expand Up @@ -28,15 +28,15 @@
"url": "https://github.com/opendecide/ngx-segment-analytics/issues"
},
"devDependencies": {
"@angular-eslint/eslint-plugin": "^16.1.0",
"@angular-eslint/eslint-plugin-template": "^16.1.0",
"@angular-eslint/template-parser": "^16.1.0",
"@angular/common": "^16.1.8",
"@angular/compiler": "^16.1.8",
"@angular/compiler-cli": "^16.1.8",
"@angular/core": "^16.1.8",
"@angular/platform-browser": "^16.1.8",
"@angular/platform-browser-dynamic": "^16.1.8",
"@angular-eslint/eslint-plugin": "^17.1.0",
"@angular-eslint/eslint-plugin-template": "^17.1.0",
"@angular-eslint/template-parser": "^17.1.0",
"@angular/common": "^17.0.3",
"@angular/compiler": "^17.0.3",
"@angular/compiler-cli": "^17.0.3",
"@angular/core": "^17.0.3",
"@angular/platform-browser": "^17.0.3",
"@angular/platform-browser-dynamic": "^17.0.3",
"@compodoc/compodoc": "^1.1.21",
"@segment/analytics-next": "^1.53.3",
"@types/jasmine": "^4.3.5",
Expand All @@ -54,16 +54,16 @@
"karma-coverage-istanbul-reporter": "^3.0.3",
"karma-jasmine": "^5.1.0",
"karma-jasmine-html-reporter": "^2.1.0",
"ng-packagr": "^16.1.0",
"ng-packagr": "^17.0.0",
"protractor": "~7.0.0",
"rxjs": "^7.8.1",
"ts-node": "^10.9.1",
"tslib": "^2.6.1",
"typescript": "~5.1.6",
"zone.js": "^0.13.1"
"typescript": "~5.2.2",
"zone.js": "0.14.2"
},
"engines": {
"node": ">=16"
"node": ">=18"
},
"packageManager": "yarn@3.2.0"
}
6 changes: 3 additions & 3 deletions src/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngx-segment-analytics",
"version": "16.1.0",
"version": "17.0.0",
"description": "Segment Analytics for Angular",
"repository": {
"type": "git",
Expand All @@ -19,8 +19,8 @@
"url": "https://github.com/opendecide/ngx-segment-analytics/issues"
},
"peerDependencies": {
"@angular/common": ">=12.0.0 <17.0.0",
"@angular/core": ">=12.0.0 <17.0.0",
"@angular/common": ">=12.0.0 <18.0.0",
"@angular/core": ">=12.0.0 <18.0.0",
"@segment/analytics-next": "^1.35.1"
}
}
Loading

0 comments on commit fef1d15

Please sign in to comment.