fix: check None before returning config

openedx · Aug 4, 2023 · a7b6a64 · a7b6a64
1 parent 159cff9
commit a7b6a64
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -16,6 +16,7 @@ Unreleased
 
 * Switch from ``edx-sphinx-theme`` to ``sphinx-book-theme`` since the former is
   deprecated
+* Fixed ConfigurationModel.current: before returning current config it would make sure it's not None.
 
 [2.3.0] - 2022-01-19
 ~~~~~~~~~~~~~~~~~~~~

diff --git a/config_models/models.py b/config_models/models.py
@@ -131,7 +131,7 @@ def current(cls, *args):
         """
         cache_key = cls.cache_key_name(*args)
         cached_response = TieredCache.get_cached_response(cache_key)
-        if cached_response.is_found:
+        if cached_response.is_found and cached_response.value is not None:
             return cached_response.value
 
         key_dict = dict(zip(cls.KEY_FIELDS, args))