Skip to content

Commit

Permalink
fix: quality
Browse files Browse the repository at this point in the history
  • Loading branch information
justinhynes committed Jul 11, 2024
1 parent 56ba73e commit 89d848e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion src/account-settings/JumpNav.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { injectIntl, intlShape } from '@edx/frontend-platform/i18n';
import { breakpoints, useWindowSize, Icon } from '@openedx/paragon';
import { OpenInNew } from '@openedx/paragon/icons';
import classNames from 'classnames';
import PropTypes from 'prop-types';
import React from 'react';
import { useSelector } from 'react-redux';
import { NavHashLink } from 'react-router-hash-link';
Expand Down
5 changes: 2 additions & 3 deletions src/account-settings/data/service.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { getConfig } from '@edx/frontend-platform';
import { getAuthenticatedHttpClient } from '@edx/frontend-platform/auth';
import pick from 'lodash.pick';
import pickBy from 'lodash.pickby';
import omit from 'lodash.omit';
import isEmpty from 'lodash.isempty';

Expand Down Expand Up @@ -191,7 +190,7 @@ export async function postVerifiedName(data) {
* A single function to GET everything considered a setting. Currently encapsulates Account, Preferences, and
* ThirdPartyAuth.
*/
export async function getSettings(username, userRoles, userId) {
export async function getSettings(username, userRoles) {

Check warning on line 193 in src/account-settings/data/service.js

View check run for this annotation

Codecov / codecov/patch

src/account-settings/data/service.js#L193

Added line #L193 was not covered by tests
const [
account,
preferences,
Expand Down Expand Up @@ -219,7 +218,7 @@ export async function getSettings(username, userRoles, userId) {
* A single function to PATCH everything considered a setting.
* Currently encapsulates Account, Preferences, ThirdPartyAuth
*/
export async function patchSettings(username, commitValues, userId) {
export async function patchSettings(username, commitValues) {

Check warning on line 221 in src/account-settings/data/service.js

View check run for this annotation

Codecov / codecov/patch

src/account-settings/data/service.js#L221

Added line #L221 was not covered by tests
// Note: time_zone exists in the return value from user/v1/accounts
// but it is always null and won't update. It also exists in
// user/v1/preferences where it does update. This is the one we use.
Expand Down

0 comments on commit 89d848e

Please sign in to comment.