-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: long email field on account page #1024
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @bydawen! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@bydawen I've invited you the triage team which will allow tests to run automatically in the future, please accept that invite when you receive it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 119 119
Lines 2495 2495
Branches 673 673
=======================================
Hits 1417 1417
Misses 1004 1004
Partials 74 74 ☔ View full report in Codecov by Sentry. |
Hi @openedx/2u-aperture! This, along with its backport, are ready for review. |
Hi @mphilbrick211 Apologies for the delay. I am under the impression that the @openedx/2u-vanguards will be the maintainers of the Account MFE moving forward. |
Hi @hurtstotouchfire - can you confirm if Aperture will be maintaining this repo? |
Hi @openedx/2u-vanguards! This is ready for review along with its backport. Thanks! |
@mphilbrick211 @openedx/2u-vanguards It seems like it is ready for review and merge. Could we speed it up, please? |
Hi @openedx/2u-vanguards - are you still maintaining this repo? If so, could you please give this a look? Thanks! (cc: @openedx/edx-infinity) |
@openedx/2u-infinity flagging for you. Thanks! |
Similar PR is opened to the open-release/quince branch:
#1025
Fix for the long email field to prevent page break for the mobile view:
If user has a long type email it will be overlap from content of page:
After fix: