-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added country disabling feature #1116
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2u-main #1116 +/- ##
===========================================
+ Coverage 58.61% 58.70% +0.09%
===========================================
Files 117 117
Lines 2317 2332 +15
Branches 641 645 +4
===========================================
+ Hits 1358 1369 +11
- Misses 898 902 +4
Partials 61 61 ☔ View full report in Codecov by Sentry. |
} | ||
|
||
return countryList.filter(({ value }) => { | ||
const isDisabled = this.isDisabledCountry(value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to recalculate isDisabled here since we are already receiving disabled as a parameter in the countryList. as countryList.filter(({ value , disabled})
* feat: added country disabling feature * refactor: removed isDisabledCountry additional call
* fix(deps): update dependency @openedx/frontend-slot-footer to v1.0.5 * fix(deps): update dependency core-js to v3.38.1 * chore(deps): update dependency @openedx/frontend-build to v14.1.4 * fix(deps): update react-router monorepo to v6.26.2 * chore: added notificationTitle for oraGradeAssigned * feat: added country disabling feature (#1116) * feat: added country disabling feature * refactor: removed isDisabledCountry additional call --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: eemaanamir <eemaan.amir@gmail.com> Co-authored-by: Eemaan Amir <57627710+eemaanamir@users.noreply.github.com>
* feat: added country disabling feature * refactor: removed isDisabledCountry additional call
* fix(deps): update dependency @openedx/frontend-slot-footer to v1.0.5 * fix(deps): update dependency core-js to v3.38.1 * chore(deps): update dependency @openedx/frontend-build to v14.1.4 * fix(deps): update react-router monorepo to v6.26.2 * chore: added notificationTitle for oraGradeAssigned * feat: added country disabling feature (#1116) * feat: added country disabling feature * refactor: removed isDisabledCountry additional call --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: eemaanamir <eemaan.amir@gmail.com> Co-authored-by: Eemaan Amir <57627710+eemaanamir@users.noreply.github.com>
* feat: added country disabling feature * refactor: removed isDisabledCountry additional call
* feat: added country disabling feature * refactor: removed isDisabledCountry additional call
* feat: added country disabling feature * refactor: removed isDisabledCountry additional call
INF-1567
Description
disabledCountries
list will no longer be visible to users in the account settings of other countries, and users will not be able to switch to disabled countries.For Example, if Russia is on the disabled countries list.
Note