Skip to content

Commit

Permalink
* fix: updating paragon version to get ModalPopup component error fix (
Browse files Browse the repository at this point in the history
…#654)

* fix: updating paragon version to get ModalPopup component error fix

* docs: tweaking readme for clarity

* fix: revoke modal popup button styling
  • Loading branch information
christopappas authored Dec 6, 2021
1 parent a86b8b8 commit 3392321
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 7 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,16 @@ $ git clone git@github.com:edx/frontend-app-admin-portal.git
$ cd frontend-app-admin-portal
$ nvm use (if using nvm) OR install and switch to version of node/npm as per the .nvmrc file to avoid issues during npm install or npm start (and to use the same version of node/npm as used by team plus CI builds)
$ npm install
$ npm start
$ npm start # or "npm run start:with-theme" if you want edX branding
```

The application is now running and can be accessed in a web browser at http://localhost:1991/


#### Themes

By default, the core Paragon theme is installed and used with the `npm start` command. If you'd like to use the @edx/brand-edx.org theme, use the `npm run start:with-theme` command.

The application is now running and can be accessed in a web browser at http://localhost:1991/

#### Sign-in and access

Expand Down
21 changes: 18 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@edx/frontend-enterprise-logistration": "0.1.11",
"@edx/frontend-enterprise-utils": "1.1.1",
"@edx/frontend-platform": "1.11.0",
"@edx/paragon": "^16.16.0",
"@edx/paragon": "^16.20.1",
"@fortawesome/fontawesome-svg-core": "1.2.35",
"@fortawesome/free-brands-svg-icons": "5.15.3",
"@fortawesome/free-regular-svg-icons": "5.15.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ const LicenseManagementTableBulkActions = ({
<Icon src={MoreVert} />
</Button>
<ModalPopup positionRef={target} isOpen={isOpen} onClose={close}>
<div>
<div className="bg-white p-2 rounded shadow">
<Button
variant="outline-danger"
iconBefore={RemoveCircle}
Expand Down

0 comments on commit 3392321

Please sign in to comment.