Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enterprise users datatable #1341

Merged
merged 7 commits into from
Nov 12, 2024
Merged

feat: add enterprise users datatable #1341

merged 7 commits into from
Nov 12, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Oct 23, 2024

Description

Adds a learners table to the modal for users to create a new group.
https://2u-internal.atlassian.net/browse/ENT-9465

UI

Screenshot 2024-10-31 at 11 48 52 AM

Screen.Recording.2024-10-31.at.11.46.15.AM.mov

Testing

  1. checkout this branch knguyen2/ent-9465 and visit link https://localhost.stage.edx.org:1991/alc-general/admin/people-management
  2. click on the 'Create group` button to navigate to the modal
  3. Verify that you can add and remove members after selecting each row.
  4. Verify that you can add and remove members by selecting the entire table.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 54.73684% with 43 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (0f957c5) to head (8396975).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ement/data/hooks/useEnterpriseLearnersTableData.js 6.06% 31 Missing ⚠️
...nents/PeopleManagement/CreateGroupModalContent.jsx 50.00% 6 Missing ⚠️
...t/invite-modal/EnterpriseCustomerUserDatatable.jsx 92.85% 3 Missing ⚠️
src/data/services/LmsApiService.js 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   85.78%   85.55%   -0.23%     
==========================================
  Files         598      600       +2     
  Lines       13121    13212      +91     
  Branches     2776     2782       +6     
==========================================
+ Hits        11256    11304      +48     
- Misses       1800     1843      +43     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 marked this pull request as ready for review October 31, 2024 18:54
@katrinan029 katrinan029 requested a review from a team October 31, 2024 18:54
@katrinan029 katrinan029 merged commit ba8fc56 into master Nov 12, 2024
4 of 6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9465 branch November 12, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants