Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add download csv button to people management #1369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marlonkeating
Copy link
Contributor

Jira Ticket

This change adds a button for downloading the filtered results of the people table on the People Management tab.

Testing Instructions

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.79%. Comparing base (383989c) to head (2524094).

Files with missing lines Patch % Lines
...gement/data/hooks/useEnterpriseMembersTableData.js 20.00% 4 Missing ⚠️
.../components/PeopleManagement/DownloadCSVButton.jsx 93.75% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1369   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files         609      610    +1     
  Lines       13384    13428   +44     
  Branches     2780     2828   +48     
=======================================
+ Hits        11483    11521   +38     
- Misses       1831     1837    +6     
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test: Add DownloadCsvButton unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant