Added waffle flag state for Courseware Search #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijuma
changed the title
rijuma
force-pushed
the
rijuma/courseware-search-waffle-flags
branch
3 times, most recently
from
d2a5202
to
c3eaded
Compare
rijuma
force-pushed
the
rijuma/courseware-search-waffle-flags
branch
8 times, most recently
from
a65fb4b
to
e99fc14
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
+ Coverage 88.05% 88.09% +0.04%
==========================================
Files 266 268 +2
Lines 4519 4537 +18
Branches 1143 1145 +2
==========================================
+ Hits 3979 3997 +18
Misses 526 526
Partials 14 14
☔ View full report in Codecov by Sentry. |
rijuma
changed the title
rijuma
commented
Oct 11, 2023
rijuma
force-pushed
the
rijuma/courseware-search-waffle-flags
branch
from
e99fc14
to
30a0f3f
Compare
rijuma
force-pushed
the
rijuma/courseware-search-waffle-flags
branch
from
30a0f3f
to
2d243a5
Compare
This was referenced Oct 25, 2023
CefBoud
pushed a commit
to open-craft/frontend-app-learning
that referenced
this pull request
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: KBK-36 (internal)
This relates to an
edx-platformPR which adds the endpoint to the LMS (openedx/edx-platform#33372)There's a project to add
edx-searchinto the course home. Right now I'm creating a placeholder button which will respond to the Course Waffle Flag toggle ofcourseware.mfe_courseware_search.UI changes
If the flag is enabled, a search button will be shown on the course's home navigation. I'm using the
floatproperty to position itself, which might sound controversial. This was the easiest way to achieve it since theCourseTabsNavigationcomponent has a wrapping logic whenever the navigation items don't fit. I've tried to move the navigation to a flex container but it just messes up with this logic. Luckily, the button is small enough so it does not interfere with the remaining space after folding.Testing Instructions:
Navigate to the LMS Admin and toggle
courseware.mfe_courseware_searchflag via:http://(...)/admin/waffle/flag/http://(...)/admin/waffle_utils/waffleflagorgoverridemodel/Results:
You should be able to see the search placeholder or not (see screenshot above) depending on the enabled state for the Waffle Flag.