Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow plugin.modal to open a fullscreen modal #1243

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

muselesscreator
Copy link
Contributor

Small pull request to allow plugin.modal messages to open a fullscreen modal by passing an isFullscreen argument to the message.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bce25c4) 87.30% compared to head (ff7e700) 87.30%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1243   +/-   ##
=======================================
  Coverage   87.30%   87.30%           
=======================================
  Files         275      275           
  Lines        4717     4719    +2     
  Branches     1190     1192    +2     
=======================================
+ Hits         4118     4120    +2     
  Misses        580      580           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@muselesscreator muselesscreator merged commit 4e13467 into master Dec 4, 2023
6 checks passed
@muselesscreator muselesscreator deleted the bw/fullscreen-modal branch December 4, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants