fix: Use Paragon Tab Component #1448
Conversation
|
Thanks for the pull request, @qasimgulzar! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
brian-smith-tcril
added
the
create-sandbox
|
Sandbox deployment successful 🚀 |
|
Noted broken tests, I will be taking care of it |
|
@qasimgulzar Just to understand better, does this PR change any user-facing functionality? Or does it just change the way that existing functionality is implemented? If it's the former, it would likely be necessary to get product approval before moving forward with engineering review here. CC @openedx/committers-frontend-app-learning @brian-smith-tcril |
|
Sandbox deployment successful 🚀 |
It is not actually changing the functionality or the use experience. It is just to replace the navigation component with Paragon's Tab component. |
|
Sandbox deployment successful 🚀 |
|
@qasimgulzar I see, thanks for the info. No need to send this PR through the product review process then. Let us know when the build is green so we can get started with engineering review. |
|
Sandbox deployment successful 🚀 |
| // unitId: PropTypes.string, | ||
| }; | ||
|
|
||
| export default injectIntl(CoursewarePage); |
There was a problem hiding this comment.
This is minor, but please use useIntl(); instead of injectIntl in any new components, and avoid defining defaultProps which is deprecated in React for function components.
| <Tabs | ||
| variant="tabs" | ||
| defaultActiveKey={activeKey} | ||
| id="uncontrolled-tab-example" |
There was a problem hiding this comment.
This id seems wrong?
| </main> | ||
|
|
||
| {/* courseStatus 'failed' and any other unexpected course status. */} | ||
| {(!['loading', 'loaded', 'denied'].includes(courseStatus)) && ( |
There was a problem hiding this comment.
Can these 'loading', 'loaded', 'denied' be loaded from an enum or constant somewhere?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
==========================================
- Coverage 88.88% 88.28% -0.60%
==========================================
Files 307 311 +4
Lines 5288 5379 +91
Branches 1345 1381 +36
==========================================
+ Hits 4700 4749 +49
- Misses 572 614 +42
Partials 16 16 ☔ View full report in Codecov by Sentry. |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
itsjeyd
added
the
waiting on author
|
Hey @qasimgulzar, just checking in to see if you're still planning to continue working on this PR? |
|
Sandbox deployment failed 💥 |
tabs-demo.mov
Click here to check original github issue