-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Untranslatable strings in Instructor Toolbar #1193 #1449 #1505
Conversation
Thanks for the pull request, @jciasenza! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1505 +/- ##
==========================================
+ Coverage 88.70% 89.24% +0.54%
==========================================
Files 313 316 +3
Lines 5505 5549 +44
Branches 1328 1369 +41
==========================================
+ Hits 4883 4952 +69
+ Misses 605 581 -24
+ Partials 17 16 -1 ☔ View full report in Codecov by Sentry. |
Fix: Untranslatable strings
Fixes #1193
What changed?
Add message ids and add a file
src/instructor-toolbar/messages.ts
Also modify the masquerade
src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx
Change useIntl instead of injectIntl
Channge: component form in a JSX context
If you approve my changes I will push them,
or if something needs to be modified let me know thanks !!!
Atte
Juan Carlos (Aulasneo)
Developer Checklist
Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
I've done a visual code review
I've tested the new functionality
FYI: @openedx/content-aurora