Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated lock file version check to use new workflow #115

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Aug 25, 2023

Renamed lockfileversion-check-v3 to lockfile-check in lockfile version file.

Ticket

Prototype a way to review NPM lockfiles in PRs

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (8457727) 94.13% compared to head (57b3351) 93.23%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/timer/TimerProvider.jsx 71.42% 2 Missing ⚠️
src/core/SequenceExamWrapper.jsx 0.00% 1 Missing ⚠️
src/exam/Exam.jsx 80.00% 1 Missing ⚠️
...arding_exam/EntranceOnboardingExamInstructions.jsx 66.66% 1 Missing ⚠️
...nboarding_exam/ErrorOnboardingExamInstructions.jsx 50.00% 1 Missing ⚠️
...arding_exam/RejectedOnboardingExamInstructions.jsx 66.66% 1 Missing ⚠️
...rding_exam/SubmittedOnboardingExamInstructions.jsx 66.66% 1 Missing ⚠️
...practice_exam/EntrancePracticeExamInstructions.jsx 50.00% 1 Missing ⚠️
...ns/practice_exam/ErrorPracticeExamInstructions.jsx 50.00% 1 Missing ⚠️
...ractice_exam/SubmittedPracticeExamInstructions.jsx 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   94.13%   93.23%   -0.91%     
==========================================
  Files          71       68       -3     
  Lines        1058     1050       -8     
  Branches      289      291       +2     
==========================================
- Hits          996      979      -17     
- Misses         57       66       +9     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m changed the title refactor: update lock file version refactor: updated lock file version check to use new workflow Aug 31, 2023
Copy link

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge given that the coverage issue is independent of the change made here.

@feanil feanil merged commit 8740833 into main Feb 8, 2024
6 of 8 checks passed
@feanil feanil deleted the mashal-m/update_lockfile branch February 8, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants