Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null checking issue in exam entry #148

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

zacharis278
Copy link
Contributor

@zacharis278 zacharis278 commented Jul 19, 2024

Hidden code issue uncovered by #147

This will error if the learner has no attempts on the exam section. I moved this line to a point where we've already checked that an exam attempt exists. Actually this is already checked earlier in the function, the value would always be false.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (c41adcb) to head (07b92a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   94.16%   94.16%   -0.01%     
==========================================
  Files          68       68              
  Lines        1080     1079       -1     
  Branches      294      295       +1     
==========================================
- Hits         1017     1016       -1     
  Misses         58       58              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharis278 zacharis278 merged commit fd8a9d7 into main Jul 19, 2024
8 checks passed
@zacharis278 zacharis278 deleted the zhancock/fix-null-check branch July 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants