fix: fixed ModalDialog.Header sizes (#2925)

* fix: fixed ModalDialog.Header sizes * refactor: refactoring after review
openedx · Dec 13, 2023 · 5af0b51 · 5af0b51
1 parent 8ef95bc
commit 5af0b51
Showing 1 changed file with 12 additions and 20 deletions.
diff --git a/src/Modal/_ModalDialog.scss b/src/Modal/_ModalDialog.scss
@@ -26,6 +26,18 @@
     max-height: none;
     margin: $modal-dialog-margin;
   }
+
+  .pgn__modal-header {
+    padding-bottom: calc(#{$modal-inner-padding} / 2);
+  }
+
+  .pgn__modal-body {
+    padding: calc(#{$modal-inner-padding} / 2) $modal-inner-padding;
+
+    &::before {
+      top: calc(#{$modal-inner-padding} / 2 * -1);
+    }
+  }
 }
 
 // Sizes
@@ -230,22 +242,6 @@
 
 // Color Variants
 
-.pgn__modal-default {
-  // Default style modals don't have a background on the header which
-  // ends up looking spaced too far away from the body content.
-  .pgn__modal-header {
-    padding-bottom: calc(#{$modal-inner-padding} / 2);
-  }
-
-  .pgn__modal-body {
-    padding: calc(#{$modal-inner-padding} / 2) $modal-inner-padding;
-
-    &::before {
-      top: calc(#{$modal-inner-padding} / 2 * -1);
-    }
-  }
-}
-
 .pgn__modal-dark {
   .pgn__modal-header,
   .pgn__modal-hero {
@@ -256,10 +252,6 @@
       color: inherit;
     }
   }
-
-  .pgn__modal-header {
-    border-bottom: solid 1px $light;
-  }
 }
 
 .pgn__modal-warning .pgn__modal-header {