-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for React 18, bump Gatsby to v5 #3367
Open
bradenmacdonald
wants to merge
37
commits into
release-22.x
Choose a base branch
from
braden/react-gatsby-bump
base: release-22.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 34 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
453554e
feat: bump packages to support React 18
bradenmacdonald 23247bd
chore: changes to migrate to gatsby-plugin-mdx v5
bradenmacdonald 2dd6935
chore: misc gatsby GraphQL syntax updates
bradenmacdonald 0f6004f
chore: fix markdown syntax issues ('<' and '{' now require escaping)
bradenmacdonald 48aa670
fix: get markdown rendering of 'description' in Props Tables working …
bradenmacdonald 60e534c
refactor: convert gatsby-config to ESM
bradenmacdonald 11b7605
fix: add 'rehype-mdx-code-props' plugin to get live code blocks working
bradenmacdonald c39b6d0
chore: fix some types/props issues in 'www'
bradenmacdonald b1b1fc8
fix: render `inline code` correctly
bradenmacdonald bbf0f3f
fix: ignore/resolve some random typescript warnings
bradenmacdonald c92a1a2
fix: "Do not define components during render", remove duplicate props…
bradenmacdonald 53500ee
chore: update imports for 'renderHook' (now part of @testing-library/…
bradenmacdonald 0c7b8bb
chore: ignore usage of deprecated React API for now
bradenmacdonald 958f617
chore: fix use of deprecated global functions in sass files
bradenmacdonald 6946d67
fix: suppress some SASS deprecation warnings for now
bradenmacdonald f67d1f7
fix: limit parallelization of build to avoid OOM error during 'develop'
bradenmacdonald 2ae234d
fix: set correct slug for each page node in gatsby
bradenmacdonald c5ca0a5
test: update test cases
bradenmacdonald e6336f5
fix: enable FAST_DEV/DEV_SSR to avoid OOM when starting Gatsby dev se…
bradenmacdonald 1942f03
test: update test cases
bradenmacdonald e0a3539
fix: use the right layout for rendering .mdx pages in www/src/pages/
brian-smith-tcril aed4ef4
fix: error loading data for CSS Utilities page
bradenmacdonald 8abf42c
fix: error loading data for Layout page
bradenmacdonald be8e10a
test: update test cases
bradenmacdonald 1f55446
chore: fix lint issues
bradenmacdonald 6db7604
chore: fix stylelint issues (required upgrading stylelint)
bradenmacdonald 505c4ba
chore: update with latest release-22.x branch
bradenmacdonald 543c9b0
fix: Gatsby webpack conflicts b/w e.g. 'useToggle.tsx' and 'useToggle…
bradenmacdonald 2b59bb2
fix: bump gatsby-link version to avoid type error with navigate()
bradenmacdonald 7fbf83e
fix: minor TypeScript error
bradenmacdonald 38d736f
fix: pin @edx/browserslist-config to avoid boilerplate in icon dist f…
bradenmacdonald b77c6a9
fix: margins, title, live code, and hot reloading on "Layout" and "CS…
bradenmacdonald 4ddc476
fix: previous commit to fix "Layout"+"CSS Utilities" pages broke docs
bradenmacdonald 64ccf2b
fix: "Theme Variables" were not appearing on component pages (docs)
bradenmacdonald 1f585af
chore: fixup previous commit (fix whitespace lint)
bradenmacdonald 6be0094
fix: stricter typing for LinkedHeading
bradenmacdonald 8979107
fix: more Gatsby webpack conflicts b/w e.g. 'useToggle.tsx' and 'useT…
bradenmacdonald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
extends: [ | ||
'@edx/eslint-config', | ||
], | ||
root: true, // Don't also import the paragon eslint config in the parent directory. | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[clarification] Why is
@edx/frontend-build
moved to a regular dependency vs. keeping it as a dev dependency?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the example MFE (not Paragon itself), and I'm following the best practice I established for MFEs that "dependencies" are what you need to build it (before deploying), and "devDependencies" are for development-only things like tests and linting.
If we had a part of the MFE that runs on the server, it would be different, but there's no server-side code here.