feat: support build arg to pin the python3 version #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a build arg to the python3 templates so that developers can pin the python version. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
|
I don't know why the CI failed, i can't replicate it locally |
|
@alexellis i still can't reproduce the CI error, i have no idea what is wrong. Do you? |
|
From what I can see, it's unrelated to your change, so I'll get this merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a build arg to the python3 templates so that developers can pin the python version.
Motivation and Context
Relates to openfaas/python-flask-template#67 and keeps the Python templates consistent.
How Has This Been Tested?
Manually tested with the default "echo" function
Types of changes
Impact to existing users
None, the current templates are equivalent and track the default latest python3 tag, the only change is the support to pin it to a specific tag via a build arg.
Checklist:
git commit -s