fix: error correctly if apiUrl is not provided (#161)

openfga · Oct 18, 2024 · ac1e4bb · ac1e4bb
2 parents 2ff8810 + 93a7cbe
commit ac1e4bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/client.ts b/client.ts
@@ -211,8 +211,6 @@ export class OpenFgaClient extends BaseAPI {
       this.configuration = new ClientConfiguration(configuration);
     }
     this.configuration.isValid();
-
-
     this.api = new OpenFgaApi(this.configuration, axios);
     this.storeId = configuration.storeId;
     this.authorizationModelId = configuration.authorizationModelId;

diff --git a/configuration.ts b/configuration.ts
@@ -186,10 +186,9 @@ export class Configuration {
    * @throws {FgaValidationError}
    */
   public isValid(): boolean {
-    if (!this.apiUrl) {
-      assertParamExists("Configuration", "apiScheme", this.apiScheme);
-      assertParamExists("Configuration", "apiHost", this.apiHost);
-    }
+    if (!this.apiUrl && !this.apiHost) {
+         assertParamExists("Configuration", "apiUrl", this.apiUrl);
+       }
 
     if (!isWellFormedUriString(this.getBasePath())) {
       throw new FgaValidationError(