Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error handling for EvalPoly and EvalChebyshev/Degree #561

Merged

Conversation

dsuponitskiy
Copy link
Collaborator

No description provided.

@dsuponitskiy dsuponitskiy added the bug Something isn't working label Sep 29, 2023
@dsuponitskiy dsuponitskiy added this to the Release 1.1.2 milestone Sep 29, 2023
@dsuponitskiy dsuponitskiy self-assigned this Sep 29, 2023
@dsuponitskiy dsuponitskiy changed the base branch from main to dev September 29, 2023 18:54
@dsuponitskiy
Copy link
Collaborator Author

All CI jobs succeeded.

Copy link
Collaborator

@jbates-duality jbates-duality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward additional error handling. Approving.

@jbates-duality jbates-duality merged commit 0a7f39c into dev Oct 3, 2023
18 checks passed
@dsuponitskiy dsuponitskiy deleted the 558-add-error-handling-for-evalpoly-and-evalchebyshev branch October 13, 2023 03:10
@dsuponitskiy dsuponitskiy restored the 558-add-error-handling-for-evalpoly-and-evalchebyshev branch October 13, 2023 03:10
@dsuponitskiy dsuponitskiy deleted the 558-add-error-handling-for-evalpoly-and-evalchebyshev branch October 13, 2023 03:10
@dsuponitskiy dsuponitskiy restored the 558-add-error-handling-for-evalpoly-and-evalchebyshev branch October 13, 2023 03:10
@dsuponitskiy dsuponitskiy deleted the 558-add-error-handling-for-evalpoly-and-evalchebyshev branch October 13, 2023 03:10
gong-cr pushed a commit to gong-cr/openfhe-development that referenced this pull request Mar 6, 2024
…g#561)

* Added fixes and error handling to EvalChebyshevCoefficients(), Degree() and EvalPoly()

* Changed a comment and replaced ssize_t with int32_t as ssize_t is not a part of standard C/C++

---------

Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegFaults are thrown for invalid parameters to EvalPoly and EvalChebyshev
5 participants