-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added error handling for EvalPoly and EvalChebyshev/Degree #561
Merged
jbates-duality
merged 2 commits into
dev
from
558-add-error-handling-for-evalpoly-and-evalchebyshev
Oct 3, 2023
Merged
Added error handling for EvalPoly and EvalChebyshev/Degree #561
jbates-duality
merged 2 commits into
dev
from
558-add-error-handling-for-evalpoly-and-evalchebyshev
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() and EvalPoly()
All CI jobs succeeded. |
… a part of standard C/C++
yspolyakov
approved these changes
Oct 3, 2023
pascoec
approved these changes
Oct 3, 2023
jbates-duality
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward additional error handling. Approving.
dsuponitskiy
deleted the
558-add-error-handling-for-evalpoly-and-evalchebyshev
branch
October 13, 2023 03:10
dsuponitskiy
restored the
558-add-error-handling-for-evalpoly-and-evalchebyshev
branch
October 13, 2023 03:10
dsuponitskiy
deleted the
558-add-error-handling-for-evalpoly-and-evalchebyshev
branch
October 13, 2023 03:10
dsuponitskiy
restored the
558-add-error-handling-for-evalpoly-and-evalchebyshev
branch
October 13, 2023 03:10
dsuponitskiy
deleted the
558-add-error-handling-for-evalpoly-and-evalchebyshev
branch
October 13, 2023 03:10
gong-cr
pushed a commit
to gong-cr/openfhe-development
that referenced
this pull request
Mar 6, 2024
…g#561) * Added fixes and error handling to EvalChebyshevCoefficients(), Degree() and EvalPoly() * Changed a comment and replaced ssize_t with int32_t as ssize_t is not a part of standard C/C++ --------- Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.