Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra keys in homomorphic decode #888

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

andreea-alexandru
Copy link
Collaborator

In the SlotsToCoefficients implementation via collapsed FFT, when the levels cannot be collapsed exactly in the given budget, there were some extra rotation keys being generated. Those extra keys are now removed.

@andreea-alexandru andreea-alexandru added the bug Something isn't working label Oct 23, 2024
@andreea-alexandru andreea-alexandru added this to the Release 1.2.2 milestone Oct 23, 2024
Copy link
Collaborator

@dsuponitskiy dsuponitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andreea-alexandru andreea-alexandru linked an issue Oct 23, 2024 that may be closed by this pull request
@dsuponitskiy dsuponitskiy merged commit 651a244 into dev Oct 23, 2024
16 of 42 checks passed
@dsuponitskiy dsuponitskiy deleted the 886-fix-findslotstocoeffsrotationindices-bug branch October 31, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix FindSlotsToCoeffsRotationIndices() bug
2 participants