Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional support for external PRNGs: make source of entropy configurable #897

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Additional support for external PRNGs: make source of entropy configurable #897

merged 4 commits into from
Oct 30, 2024

Conversation

dsuponitskiy
Copy link
Collaborator

No description provided.

@dsuponitskiy dsuponitskiy added bug Something isn't working new feature New feature or request labels Oct 30, 2024
@dsuponitskiy dsuponitskiy added this to the Release 1.2.2 milestone Oct 30, 2024
@dsuponitskiy dsuponitskiy self-assigned this Oct 30, 2024
@dsuponitskiy dsuponitskiy linked an issue Oct 30, 2024 that may be closed by this pull request
Additional support for external PRNGs: make source of entropy configurable #896
Closed
jbates-duality
jbates-duality approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@jbates-duality jbates-duality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed and iterated with Dmitriy on this. This allows external PRNG to collect its own seed. This provides additional security/safety in the default Blake2 implementation using internally by OpenFHE. Approving.

jbates-duality
jbates-duality approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@jbates-duality jbates-duality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after verifying Blake2Engine destructor clears m_seed, and commentary update.

@yspolyakov yspolyakov merged commit c5488d8 into dev Oct 30, 2024
26 checks passed
@dsuponitskiy dsuponitskiy deleted the 896-prngs-configurable branch October 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbates-duality jbates-duality jbates-duality approved these changes

Assignees

@dsuponitskiy dsuponitskiy

Labels
bug Something isn't working new feature New feature or request
Projects
None yet
Milestone
Release 1.2.3
Development

Successfully merging this pull request may close these issues.

Additional support for external PRNGs: make source of entropy configurable
4 participants
@dsuponitskiy @jbates-duality @yspolyakov @dsuponitskiy-duality