Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deplace dependance click vers test #237

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Deplace dependance click vers test #237

merged 2 commits into from
Aug 29, 2023

Conversation

sylvainipp
Copy link
Contributor

Technical changes

  • Déplace click dans les dépendances de test plutôt qu'install_requires

@sylvainipp sylvainipp linked an issue Aug 24, 2023 that may be closed by this pull request
Le package click 8.1.6 ne s'installe pas sur windows #236
Closed
@benoit-cty
Copy link
Contributor

benoit-cty commented Aug 28, 2023 •
edited
Loading

Bonjour Sylvain, Je ne sais pas si c'est idéal de le mettre dans test car il y a input_data_builder qui l'utilise.
Le besoin est de retirer click des projets qui importent france-data ?
EDIT : Pardon, je vois que dans france-data il n'y a pas de [dev], seulement [test] et que c'est ce qui est installé par make install donc c'est un bon choix.
D'ailleurs, la dépendance matplotlib est-elle toujours d'actualité ? Car il ne semble pas importé.

benoit-cty
benoit-cty approved these changes Aug 28, 2023
View reviewed changes
setup.py Outdated
@@ -38,7 +38,6 @@
},
python_requires = ">=3.9",
install_requires = [
"click >=8.0.0, <9.0.0",
"matplotlib >=3.1.1, <4.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retirer matplotlib ?

Copy link
Contributor Author

@sylvainipp sylvainipp Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci ! En effet, je vais enlever matplotlib, l'erreur qui a donné lieu à son rajout dans la PR d'origine semble assez explicite et on devrait donc facilement résoudre le problème s'il revient.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, d'accord, il pourrait être dans un extra dédié si toujours nécessaire.

@sylvainipp sylvainipp merged commit 0fa4182 into master Aug 29, 2023
12 checks passed
@clallemand clallemand deleted the click_into_test branch November 7, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit-cty benoit-cty benoit-cty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Le package click 8.1.6 ne s'installe pas sur windows
2 participants
@sylvainipp @benoit-cty