Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout du Bail Réel Solidaire #2404

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

Shamzic
Copy link
Contributor

@Shamzic Shamzic commented Dec 19, 2024

  • Évolution du système socio-fiscal.
  • Périodes concernées : à partir du 01/07/2024.
  • Zones impactées :
    • openfisca_france/parameters/prestations_sociales/bail_reel_solidaire/plafonds_par_zones
    • openfisca_france/model/prestations/bail_reel_solidaire.py
    • tests/formulas/bail_reel_solidaire.yaml
  • Détails :
    • Ajout du dispositif Bail Réel Solidaire
    • Ajout des plafonds de ressources selon la zone et le nombre de personnes du foyer
    • Ajout du fichier csv de zones pour le BRS

Ces changements :

  • Ajoutent une fonctionnalité (ajout d'une variable).

Quelques conseils à prendre en compte :

Et surtout, n'hésitez pas à demander de l'aide ! :)

@Shamzic Shamzic marked this pull request as draft December 19, 2024 19:06
@Shamzic
Copy link
Contributor Author

Shamzic commented Dec 30, 2024

Après des recherches infructueuses, je n'arrive pas à trouver les plafonds sur Légifrance, je suis donc contraint de conserver la source de service-public.fr ...

@Shamzic Shamzic marked this pull request as ready for review January 1, 2025 10:34
Copy link
Contributor

@jenovateurs jenovateurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques petites questions, sinon tout me paraît plutôt correcte.

openfisca_france/model/prestations/bail_reel_solidaire.py Outdated Show resolved Hide resolved
openfisca_france/model/prestations/bail_reel_solidaire.py Outdated Show resolved Hide resolved
openfisca_france/model/prestations/bail_reel_solidaire.py Outdated Show resolved Hide resolved
jenovateurs
jenovateurs previously approved these changes Jan 7, 2025
Copy link
Contributor

@jenovateurs jenovateurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tout me semble donc bon.

@Shamzic Shamzic force-pushed the ajoute-bail-reel-solidaire branch from 5eb0919 to 69e1861 Compare January 7, 2025 17:25
@Shamzic Shamzic requested a review from jenovateurs January 7, 2025 17:26
@Shamzic
Copy link
Contributor Author

Shamzic commented Jan 7, 2025

Suite au commentaire de @benjello j'ai remodélisé l'aide pour utiliser le calcul vectoriel proprement.
Il y a probablement encore du refacto possible.

@Shamzic Shamzic dismissed jenovateurs’s stale review January 8, 2025 09:52

Remodélisation

Copy link
Contributor

@jenovateurs jenovateurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petite suggestion.

openfisca_france/model/prestations/bail_reel_solidaire.py Outdated Show resolved Hide resolved
@Shamzic Shamzic force-pushed the ajoute-bail-reel-solidaire branch from bcae354 to 5ff123b Compare January 13, 2025 14:49
@Shamzic Shamzic force-pushed the ajoute-bail-reel-solidaire branch from 5ff123b to 7d4156b Compare January 14, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants