-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [WIP] Support OpenTelemetry #10710
Draft
hangy
wants to merge
30
commits into
main
Choose a base branch
from
otel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the Dockerfile.frontend to use the nginx:stable-otel image instead of the nginx:stable image. This change is made to integrate OpenTelemetry into the frontend container.
This commit modifies the Apache2 configuration file to include the necessary PerlPostReadRequestHandler and PerlCleanupHandler directives for integrating OpenTelemetry into the request handling process. Additionally, a new Perl module, ProductOpener::Apache2PostRequestHandler, is added to handle the response and end the current span. This change improves tracing and monitoring capabilities in the application.
This commit updates the OpenTelemetry dependencies in the `cpanfile` to use the latest versions. Specifically, it updates `OpenTelemetry::SDK` to version 0.024 and `OpenTelemetry::Exporter::OTLP` to version 0.017. This update ensures that the application is using the most recent features and improvements provided by OpenTelemetry. jjatria/perl-opentelemetry-sdk#16
This commit updates the `OTEL_EXPORTER_OTLP_ENDPOINT` environment variable in the `.env` file and `modperl.conf` to use the new endpoint `http://otel-collector:4318`. This change ensures that the application is sending telemetry data to the correct endpoint for OpenTelemetry export with HTTP instead of GRPC, as the Perl module doesn't understand GRPC, yet.
This commit updates the `OTEL_SERVICE_NAME` and `OTEL_RESOURCE_ATTRIBUTES` environment variables in the `.env` file, `modperl.conf`, and `default.conf.template` to reflect the changes made for OpenTelemetry integration. These updates ensure that the application is correctly configured to send telemetry data to the designated service and with the appropriate resource attributes.
github-actions
bot
added
Data import
🖼️ Images
🪶 Apache
We use Apache as a server to run Open Food Facts
NGINX
🐋 Docker
https://docker-curriculum.com/
dependencies
Pull requests that update a dependency file
🏭 Producers Platform
https://wiki.openfoodfacts.org/Platform_for_producers
🥗🔍 Ingredients analysis
https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis
Display
Products
Tags
📨 Mail
📨 Emails - Brevo
🥗 Ingredients
labels
Aug 17, 2024
…to use Apache2::Const The code changes import the `Apache2::Const` module in the `ProductOpener::Apache2PostRequestHandler` and `ProductOpener::Apache2PreRequestHandler` files. This change is made to use the constants provided by the `Apache2::Const` module in the code.
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🪶 Apache
We use Apache as a server to run Open Food Facts
Data import
dependencies
Pull requests that update a dependency file
Display
🐋 Docker
https://docker-curriculum.com/
📨 Emails - Brevo
🖼️ Images
🥗🔍 Ingredients analysis
https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis
🥗 Ingredients
📨 Mail
💥 Merge Conflicts
💥 Merge Conflicts
NGINX
🏭 Producers Platform
https://wiki.openfoodfacts.org/Platform_for_producers
Products
Tags
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
OpenTelemetry::SDK
and some automatic instrumentation to the Perl code to forward traces to a configure otel collector. Also uses the nginx container with otel support to include it in the whole trace. Additionally we use theLWP::UserAgent
integration to trace HTTP calls, which might turn out helpful with off-query, and with Keycloak. MongoDB is traced using themonitoring_callback
.Related issue(s) and discussion