Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logo improvements #1273

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix: logo improvements #1273

merged 3 commits into from
Oct 25, 2023

Conversation

raphael0202
Copy link
Collaborator

@raphael0202 raphael0202 commented Oct 25, 2023

  • reduce number of k nearest neighbors to consider to 10 (instead of 100). We have a much better annotation coverage as at the beginning of the project, and 100 generates too many false positive, and prevent a correct brand logo detection.
  • improve logo DB update CLI command

KNN is much better now, and we have a better logo coverage.
K_NEAREST_NEIGHBORS=100 led to too many false positive, and prevented
most brands from having matches.
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1273 (81311a0) into main (dd6d81e) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
- Coverage   56.53%   56.51%   -0.02%     
==========================================
  Files          77       77              
  Lines        7465     7467       +2     
==========================================
  Hits         4220     4220              
- Misses       3245     3247       +2     
Files Coverage Δ
robotoff/settings.py 91.94% <100.00%> (ø)
robotoff/cli/main.py 14.44% <0.00%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raphael0202 raphael0202 merged commit c67b8ff into main Oct 25, 2023
10 of 12 checks passed
@raphael0202 raphael0202 deleted the logo-improvements branch October 25, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants