Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logos improvements #1286

Merged
merged 5 commits into from
Nov 7, 2023
Merged

fix: logos improvements #1286

merged 5 commits into from
Nov 7, 2023

Conversation

raphael0202
Copy link
Collaborator

@raphael0202 raphael0202 commented Nov 7, 2023

  • don't include logos from deleted images in API routes (when it makes sense not to return them)
  • delete logo embeddings (from ES and in DB), logos and image predictions of deleted images
  • improve documentation

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1286 (24c62c9) into main (56d7fe2) will increase coverage by 0.07%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   56.67%   56.74%   +0.07%     
==========================================
  Files          78       78              
  Lines        7569     7586      +17     
==========================================
+ Hits         4290     4305      +15     
- Misses       3279     3281       +2     
Files Coverage Δ
robotoff/app/core.py 91.07% <100.00%> (ø)
robotoff/images.py 45.09% <100.00%> (+8.01%) ⬆️
robotoff/logos.py 41.37% <100.00%> (+1.02%) ⬆️
robotoff/app/api.py 48.36% <0.00%> (-0.24%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@raphael0202 raphael0202 merged commit 4b7e130 into main Nov 7, 2023
13 checks passed
@raphael0202 raphael0202 deleted the logo-additions branch November 7, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant