Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix extreme weight detection for multi-packaging #1298

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

raphael0202
Copy link
Collaborator

We didn't check extreme weight for multi-packaging weight predictions.

Solves #1288.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc00a7c) 57.43% compared to head (9e50f49) 57.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
+ Coverage   57.43%   57.57%   +0.13%     
==========================================
  Files          79       79              
  Lines        7783     7785       +2     
==========================================
+ Hits         4470     4482      +12     
+ Misses       3313     3303      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 marked this pull request as ready for review January 31, 2024 09:25
@raphael0202 raphael0202 requested a review from a team as a code owner January 31, 2024 09:25
@raphael0202 raphael0202 merged commit d9660c6 into main Jan 31, 2024
10 checks passed
@raphael0202 raphael0202 deleted the fix-weight-detection branch January 31, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant