Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use openfoodfacts.ml for object detection #1493

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

raphael0202
Copy link
Collaborator

  • use ml submodule for object detection
  • add a ModelConfig pydantic class to specify model configuration. Previously, the model configuration was not clear and could lead to bugs.
  • add a threshold parameter in model predict route

- use ml submodule for object detection
- add a ModelConfig pydantic class to specify model configuration.
  Previously, the model configuration was not clear and could lead to
  bugs.
- add a `threshold` parameter in model predict route
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 55.10204% with 22 lines in your changes missing coverage. Please review.

Project coverage is 55.41%. Comparing base (bb72dce) to head (faf4c41).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
robotoff/prediction/object_detection/core.py 53.84% 18 Missing ⚠️
robotoff/app/api.py 0.00% 3 Missing ⚠️
robotoff/cli/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
+ Coverage   54.94%   55.41%   +0.47%     
==========================================
  Files          85       85              
  Lines        8855     8764      -91     
==========================================
- Hits         4865     4857       -8     
+ Misses       3990     3907      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 self-assigned this Dec 10, 2024
@raphael0202 raphael0202 merged commit 54843be into main Dec 10, 2024
9 checks passed
@raphael0202 raphael0202 deleted the refactor-object-detection branch December 10, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant