Add 'Voucher:' before voucher code on order confirmation emails

[kernal053]

What? Why?

• Closes Add "voucher:" before voucher code on order confirmation emails #12978

What should we test?

• When voucher is used in an order as a shopper, order confirmation email will contain "Voucher:" text before voucher code.
• Check also for translated "Voucher" text.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Preview (en)

Preview (es)

[mkllnk]

Nice! Thank you.

I have a suggestion below. Are you up for that?

[mkllnk]

May I suggest to use a translation here? Then we can customise the display for each language. Other possibilities could be:

• Voucher CODE:
• CODE (voucher):
• CODE (discount):

You can pass the voucher code to the translation:

Suggested change

	- if adjustment.originator_type == "Voucher"
	= "#{t(:voucher)}:"
	= "#{adjustment.label}:"
	- if adjustment.originator_type == "Voucher"
	= t(".voucher_label", code: adjustment.label)

And in en.yml I would add "Voucher %{code}:" as translation, avoiding the weird double colon in the line.