Skip to content

Commit

Permalink
Avoid circular import attempting to display "no cheminf toolkits inst…
Browse files Browse the repository at this point in the history
…alled" warning (#1690)

* avoid circular import when throwing "no cheminf toolkits installed" error

* Update releasehistory.md
  • Loading branch information
j-wags authored Aug 8, 2023
1 parent 7b94401 commit f1f2fa2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion docs/releasehistory.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ Releases follow the `major.minor.micro` scheme recommended by [PEP440](https://w
* `minor` increments add features but do not break API compatibility
* `micro` increments represent bugfix releases or improvements in documentation

## 0.14.3

### Bugfixes

- [PR #1690](https://github.com/openforcefield/openff-toolkit/pull/1690): Fixes a circular-import bug that occurs when attempting to print a "no cheminformatics toolkits available" warning.

## 0.14.2

## Behavior changes
### Behavior changes

- [PR #1679](https://github.com/openforcefield/openff-toolkit/pull/1679): Version 0.3 `<vdW>` sections of OFFXML files will automatically be up-converted (in memory) to version 0.4 according to the recomendations provided in [OFF-EP 0008](https://openforcefield.github.io/standards/enhancement-proposals/off-ep-0008/).

Expand Down
2 changes: 1 addition & 1 deletion openff/toolkit/utils/toolkits.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
break

if not any_toolkits: # pragma: no cover
from openff.toolkit.utils import all_subclasses
from openff.toolkit.utils.utils import all_subclasses

msg = "WARNING: No basic cheminformatics toolkits are available.\n"
msg += "At least one basic toolkit is required to handle SMARTS matching and file I/O. \n"
Expand Down

0 comments on commit f1f2fa2

Please sign in to comment.