Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
  • Loading branch information
nirvn and suricactus committed Nov 28, 2022
1 parent 6a96210 commit 937970a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/qml/editorwidgets/CheckBox.qml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import "."
EditorWidgetBase {
height: childrenRect.height

//if the field type is boolean, ignore the configured 'CheckedState' and 'UncheckedState' values and work with true/false always
readonly property bool isBool: field.type == 1 //needs type coercion
// if the field type is boolean, ignore the configured 'CheckedState' and 'UncheckedState' values and work with true/false always
readonly property bool isBool: field.type == 1 // needs type coercion
property bool isNull: value == undefined
property string checkedLabel: config['TextDisplayMethod'] === 1 && config['CheckedState'] != null && config['CheckedState'] !== '' ? config['CheckedState'] : qsTr('True')
property string uncheckedLabel: config['TextDisplayMethod'] === 1 && config['UncheckedState'] != null && config['UncheckedState'] !== '' ? config['UncheckedState'] : qsTr('False')
Expand Down

1 comment on commit 937970a

@qfield-fairy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.