Relation editor rework to allow for map panning/zooming to child feature #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for c336a0f: arm64-android |
nirvn
force-pushed
the
relation_goto
branch
3 times, most recently
from
f1ba257
to
92afd4b
Compare
|
FYI, this is ready for review. |
…/zoom canvas to that child feature
…prove default colors
…feature list extent controller
suricactus
approved these changes
Jul 7, 2023
|
@suricactus , thanks brother, super keen to merge these PRs ASAP to test things out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements panning/zooming to child feature UX within relation-related editor widget.
Relation editor widget
Showtime:
Screencast.from.2023-06-23.14-56-06.webm
Notice the super flashy opacity animation, which does a much better job at highlighting a feature than a static show/wait/hide
UI wise, changes include the addition of a button to open a child feature's form so we can take over the tap on child feature display text to pan/zoom the map canvas. It happens to actually be a nice move as it harmonizes the UI/UX with that of the search bar.
Relation reference widget
Showtime:
Screencast.from.2023-06-24.15-12-59.webm