Value relation editor widget autocomplete fixes and improvements #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…typed value has no match (bonus fix on enter/return action handling)
|
🎉 Ta-daaa, freshly created APKs are available for c23aa1a: arm64-android |
|
Big +1 in terms of ergonomy! |
m-kuhn
approved these changes
Jul 7, 2023
suricactus
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big UX improvement is the addition of a visual feedback that tells the user that an entered auto-complete value is not within the value relation list:
Screencast.from.2023-06-25.16-57-20.webm
The handling of the Enter/Return action has also been fixed to avoid a reset to NULL value when the user tries to submit an auto-completion via that key press.