Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the show visible feature(s) action with reprojected layers #4437

Merged
merged 1 commit into from
Jul 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/core/multifeaturelistmodel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,26 @@ void MultiFeatureListModel::setFeatures( QgsVectorLayer *vl, const QString &filt
}
if ( !extent.isEmpty() )
{
request.setFilterRect( extent );
QgsRectangle filterExtent = extent;
if ( QgsProject::instance()->crs() != vl->crs() )
{
QgsCoordinateTransform transform( QgsProject::instance()->crs(), vl->crs(), QgsProject::instance()->transformContext() );
try
{
filterExtent = transform.transform( extent );
}
catch ( const QgsException &e )
{
Q_UNUSED( e )
m-kuhn marked this conversation as resolved.
Show resolved Hide resolved
return;
}
catch ( ... )
{
// catch any other errors
return;
}
}
request.setFilterRect( filterExtent );
}
QMap<QgsVectorLayer *, QgsFeatureRequest> requests( { { vl, request } } );
mSourceModel->setFeatures( requests );
Expand Down
Loading