Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version numbering from all QML imports #5572

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Aug 17, 2024

This is legacy stuff from Qt5, and it causes erroneous warnings in QtCreator.

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Aug 17, 2024

@m-kuhn
Copy link
Member

m-kuhn commented Aug 17, 2024

@mohsenD98 can you review this?

@mohsenD98
Copy link
Collaborator

@mohsenD98 can you review this?

sure.

@mohsenD98
Copy link
Collaborator

Grate work @nirvn 👍


these files left over:

  • tst_editorwidgets.qml
  • tst_featureForm.qml
  • tst_positioning.qml
  • tst_qFieldGuide.qml

also in FeatureForm.qml [line 323] && BrowserPanel.qml [line 88]:

Qt.createQmlObject('import QtWebView 1.14

  • Sample projects tested, no issue occurred. 👍

@nirvn nirvn enabled auto-merge August 20, 2024 13:41
@nirvn nirvn merged commit b49e8ab into master Aug 20, 2024
23 checks passed
@nirvn nirvn deleted the import_remove_version branch August 20, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants