Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to NDK r26d #5578

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 19, 2024

Changelog

Sourced from burrunan/gradle-cache-action's changelog.

2024-07-25: v2, v1.21 🚀 Move to node20

  • Bump node16 to node20. This resolves "node16 is deprecated" warning.

  • Bump Gradle to 8.8

  • Bump kotlinx-coroutines to 1.8.1

  • Bump kotlin-serialization to 1.7.1

  • Bump wrapper-validation-action to v3

  • Bump setup-java, checkout to v4

2023-02-18: v1.21 🚑 bump dependencies

  • Add wrapper-validation-action
  • Bump checkout and setup-java to v3

2023-02-18: v1.20 🚑 Avoid crash on missing layer-..json file

  • fix: avoid failure when index restore misses layer-..json file
  • Migrate to kotlin-wrappers:kotlin-actions-toolkit for better Kotlin wrappers burrunan/gradle-cache-action#65
  • Bump Gradle to 8.0.1
  • Bump Kotlin to 1.8.10

2023-02-03: v1.19 🚑 Support nested version catalogs

Thanks to Vampire for the contribution.

2023-02-03: v1.18 🚑 fix crash when git log returns a string with a newline

2023-02-03: v1.17 🚀 better types for list arguments in github-workflows-kt

Thanks to Vampire for the contribution.

2023-01-23: v1.16 🚀 added types for github-workflows-kt

See burrunan/gradle-cache-action#58

Thanks to Vampire for the contribution.

2022-11-27: v1.15 ⬆️ bump dependencies

Includes all the fixes from 1.13 and 1.14.

2022-10-29: v1.14 ⬆️ bump dependencies

Unreleased: the code was not compatible with kotlin-wrappers/node, so it did not work. Use 1.15 instead.

... (truncated)

Commits
  • c15634b Publish release from b330c496a960f3ede5ab212aad2649a225728800
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 19, 2024
@nirvn nirvn closed this Aug 20, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 20, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@nirvn nirvn reopened this Aug 20, 2024
@m-kuhn m-kuhn closed this Aug 21, 2024
@m-kuhn m-kuhn reopened this Aug 21, 2024
@m-kuhn m-kuhn closed this Aug 21, 2024
@dependabot dependabot bot deleted the dependabot/github_actions/burrunan/gradle-cache-action-2 branch August 21, 2024 20:21
@m-kuhn
Copy link
Member

m-kuhn commented Aug 21, 2024

Not convinced, complains about not finding the sdk. Not digging deeper.

@m-kuhn m-kuhn restored the dependabot/github_actions/burrunan/gradle-cache-action-2 branch August 22, 2024 15:46
@m-kuhn m-kuhn deleted the dependabot/github_actions/burrunan/gradle-cache-action-2 branch August 22, 2024 15:46
@m-kuhn m-kuhn restored the dependabot/github_actions/burrunan/gradle-cache-action-2 branch August 22, 2024 15:46
@m-kuhn m-kuhn reopened this Aug 22, 2024
@m-kuhn
Copy link
Member

m-kuhn commented Aug 22, 2024

After seeing the same error in other places, this might be unrelated

@m-kuhn
Copy link
Member

m-kuhn commented Aug 22, 2024

Can someone replace the ndk version in the android.yml with 26.3.11579264 ?
No keyboard here ...

@mohsenD98 ?

@nirvn
Copy link
Member

nirvn commented Aug 23, 2024

We'd also need to align the docker android build's NDK reference to r26d (== 26.3.11579264) in this file: https://github.com/opengisch/QField/blob/master/.docker/android_dev/Dockerfile

@m-kuhn m-kuhn force-pushed the dependabot/github_actions/burrunan/gradle-cache-action-2 branch from 8f434bf to 4105faa Compare August 24, 2024 11:30
@m-kuhn
Copy link
Member

m-kuhn commented Aug 24, 2024

@nirvn ok for merging if ci passes?

@m-kuhn m-kuhn changed the title Bump burrunan/gradle-cache-action from 1 to 2 Switch to NDK r26d Aug 24, 2024
Copy link
Member

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much so, good work!

@m-kuhn m-kuhn enabled auto-merge August 24, 2024 12:37
@m-kuhn m-kuhn disabled auto-merge August 24, 2024 13:24
@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Aug 24, 2024

@m-kuhn
Copy link
Member

m-kuhn commented Aug 24, 2024

r27 failing because of android/ndk#2032
Let's stick to r26 for now

dependabot bot and others added 4 commits August 25, 2024 09:09
Bumps [burrunan/gradle-cache-action](https://github.com/burrunan/gradle-cache-action) from 1 to 2.
- [Release notes](https://github.com/burrunan/gradle-cache-action/releases)
- [Changelog](https://github.com/burrunan/gradle-cache-action/blob/main/CHANGELOG.md)
- [Commits](burrunan/gradle-cache-action@v1...v2)

---
updated-dependencies:
- dependency-name: burrunan/gradle-cache-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
change ndk version to 26.3.11579264
Minimum requirement imposed by Qt
@nirvn nirvn force-pushed the dependabot/github_actions/burrunan/gradle-cache-action-2 branch from f916128 to a73b01d Compare August 25, 2024 02:10
@nirvn
Copy link
Member

nirvn commented Aug 25, 2024

@m-kuhn , reverted to r26, I'll merge once it's green.

@nirvn nirvn merged commit 6b8aa98 into master Aug 25, 2024
22 of 23 checks passed
@nirvn nirvn deleted the dependabot/github_actions/burrunan/gradle-cache-action-2 branch August 25, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants