Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file association for .qgs/.qgz on Windows #5621

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Sep 7, 2024

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Sep 7, 2024

cmake/Package.cmake Outdated Show resolved Hide resolved
@nirvn
Copy link
Member Author

nirvn commented Sep 7, 2024

We shouldn't delete .qgs and .qgz extension key, this could have been changed by e.g. installing QGIS and we don't want to mess with that.

This also follows Microsoft's own recommendation not to delete that key (https://learn.microsoft.com/en-us/windows/win32/shell/fa-file-types).

@nirvn nirvn force-pushed the windows_file_association branch 3 times, most recently from 2da2f41 to 8b3bd3f Compare September 7, 2024 10:37
@nirvn nirvn force-pushed the windows_file_association branch 3 times, most recently from 78ae912 to c87bcf6 Compare September 8, 2024 03:30
@m-kuhn
Copy link
Member

m-kuhn commented Sep 8, 2024

We already have a copy of the NSIS template in place, it's probably easier to just edit that in place

@CPACK_NSIS_EXTRA_INSTALL_COMMANDS@

@nirvn nirvn merged commit 112d123 into master Sep 8, 2024
23 checks passed
@nirvn nirvn deleted the windows_file_association branch September 8, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants