Possibility to use Difference/Clip processing algorithme #5678
Conversation
qsavoye
commented
Sep 24, 2024
qsavoye
commented
- Select vector geometry features
- Click on Process Selected Features
- New algo are availabe especially from Vector Overlay group, Choose Difference algo
- Select OVERLAY layer you want
There was a problem hiding this comment.
@qsavoye , hey there, thanks for the contribution! I've added a couple of comments that'd need addressing. Looking forward to merge this :)
Could you also install the pre-commit hook to insure formatting is done so it passes our CI tests? See documentation here: https://github.com/opengisch/QField/blob/master/doc/dev.md#contribute
| context.setProject( QgsProject::instance() ); | ||
| for ( auto it = map.begin(); it != map.end(); ++it ) | ||
| { | ||
| if ( it.value()->type() == Qgis::LayerType::Vector && QgsProcessingUtils::variantToSource( it.value()->name(), context, mParameters.at( index.row() )->defaultValue() ) ) |
There was a problem hiding this comment.
@qsavoye , we didn't need the vartiantToSource here, but what we definitively needed was to do a check against the parameter's dataTypes() to filter out of vector layers that are not part of list of geometry types passed by the algorithms.
I've done that here: https://github.com/opengisch/QField/pull/5690/files#diff-15f7c96b0c450067ace3ed62a83f37fea47213c6cdefbf28bba20747ff6634d2R302
| @@ -151,8 +151,11 @@ void ProcessingAlgorithmParametersModelBase::rebuild() | |||
| mHasAdvancedParameters = true; | |||
| } | |||
|
|
|||
| mParameters << definition; | |||
| mValues << definition->defaultValue(); | |||
| if ( definition->name() != "INPUT" ) | |||
There was a problem hiding this comment.
Just to be extra safe, I've added a definition->type() == QStringLiteral( "source" ) condition here:
|
Superseded by #5690 |
