Vectorize key icons to insure we look great on high/mid/low DPI screens #5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for cf9ecbf: arm64-android |
nirvn
force-pushed
the
icon_vectorize
branch
from
15cb85f
to
7656b3e
Compare
nirvn
force-pushed
the
icon_vectorize
branch
from
b109f6f
to
cf9ecbf
Compare
m-kuhn
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing jumped at me at intergeo when showcasing QField on this nice large samsung TV: bitmap images found in a bunch of tool buttons (et al) really do us a disservice. This PR takes care of that. I took photos of the worse offenders, unfortunately it doesn't do justice of how bad it looked.
In doing so, we get rid of a bunch of PNGs, making our APK smaller by a few 100KBs :) (to be exact: 450KB or so, not insignificant).
The PR isn't taking care of all remaining ones, but insures that the main parts of QField (e.g. qgismobileapp.qml) are all using vector icons.The PR kills all remaining bitmap icons, we're not vector-only.