Add the possibility to rotate a single feature (line or polygon)

[qsavoye]

[qsavoye]

I just remove some submodules depency that I do not had to commit previously, sorry for the incovenient.

[nirvn]

@qsavoye , hey there, thanks for this contribution, it's fantastic! I'll get to review it ASAP (I've been a bit under the weather this week).

One thing I can already see as a need here is to change the icon to use a stock one from Google's material symbols & icons library: https://fonts.google.com/icons?icon.query=rotate -- that'll insure the style matches the rest of the app.

[nirvn]

@qsavoye , oh, one question: you are aware that the processing toolbox (new feature in QField 3.4) has a rotate algorithm. Is there a reason why you wouldn't be using that instead?

[qsavoye]

@qsavoye , oh, one question: you are aware that the processing toolbox (new feature in QField 3.4) has a rotate algorithm. Is there a reason why you wouldn't be using that instead?

@nirvn It's more a question of user experience. I tried the processing toolbox for rotation on my Iphone, the parameter window hides a big part of the map canvas, which can be unpleasant
Furthermore, in my opinion, it is faster to rotate with drag or mouse pointer on mapcanvas than with a precise angle in degrees. I think both are complementary.

[nirvn]

@qsavoye , hey there, sorry for the delayed review, it's been one of those months :)

This would make a great feature for QField's next release (3.5). Let me know if you have questions on the review comments.

[nirvn]

@qsavoye , thanks for addressing the review. Will merge as soon as the CIs turn green. Thanks for this contribution 🙏

[qsavoye]

@nirvn I think my there was an update between the current master and and the master where i start these pull request on file multifeaturelistmodelbase.cpp

in canRotateSelection function

if ( !vlayer || vlayer->readOnly() || !( vlayer->dataProvider()->capabilities() & QgsVectorDataProvider::ChangeGeometries ) || vlayer->customProperty( QStringLiteral( "QFieldSync/is_geometry_locked" ), false ).toBool() )

must be replace to

if ( !vlayer || vlayer->readOnly() || !( vlayer->dataProvider()->capabilities() & Qgis::VectorProviderCapability::ChangeGeometries ) || vlayer->customProperty( QStringLiteral( "QFieldSync/is_geometry_locked" ), false ).toBool() )

Do you see other change which can block the merge ?

[nirvn]

@qsavoye , no, if that's fixed, I think we can merge.

There was indeed a QGIS core library update which did change a couple of enum keys, inc. this one.

[nirvn]

@qsavoye , can you resolve the conflict too?