Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TID (OID) Configurator #844

Merged
merged 30 commits into from
Nov 24, 2023
Merged

TID (OID) Configurator #844

merged 30 commits into from
Nov 24, 2023

Conversation

signedav
Copy link
Member

@signedav signedav commented Nov 17, 2023

There are some panels:

  • The LayerTIDsPanel providing the view of all the single layers and the OID settings (and function to save)
  • The SetSequencePanel providing the current sequence (and function to save)
  • First two are summarized in TIDConfiguratorPanel having a "Reset Values" Button
  • Wizard Page TIDConfigurationPage containing TIDConfiguratorPanel and button to set (save).
  • TID (OID) manager openable by menu and saving settings with "OK".

Wizard Page

Screenshot from 2023-11-20 13-38-58

TID Manager

Open with Database > Model Baker > TID (OID) Manager

Screenshot from 2023-11-20 13-40-54

Depends on

opengisch/QgisModelBakerLibrary#69 opengisch/QgisModelBakerLibrary#68
opengisch/QgisModelBakerLibrary#71

@signedav signedav marked this pull request as draft November 17, 2023 16:08
@signedav signedav marked this pull request as ready for review November 20, 2023 12:44
Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thanks a lot

Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
signedav and others added 6 commits November 24, 2023 08:43
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
signedav and others added 3 commits November 24, 2023 08:58
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
@m-kuhn
Copy link
Member

m-kuhn commented Nov 24, 2023

I like it.

Is this something we do as best-practice?

@signedav this comment is somehow shown out of context, I assume it's about @override.
I have only found this right now, we can discuss if it should be added to best practice, apparently starting from python 3.12 (which is super new, so we cannot rely on it so far ...) there's even native support for such a construct.

@signedav
Copy link
Member Author

I'll make myself a task for override but don't introduce it here because otherwise we have it sometimes and sometimes not...

docs/background_info/oid_tid_generator.md Outdated Show resolved Hide resolved
docs/background_info/oid_tid_generator.md Outdated Show resolved Hide resolved
docs/background_info/oid_tid_generator.md Outdated Show resolved Hide resolved
@signedav signedav merged commit 56ff4db into master Nov 24, 2023
3 checks passed
@signedav signedav deleted the tid_generator branch November 24, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants